From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [patch] scsi: dpt_i2o: double free if adpt_i2o_online_hba() fails Date: Tue, 20 Dec 2016 17:46:55 -0500 Message-ID: References: <20161216093539.GC13942@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20161216093539.GC13942@elgon.mountain> (Dan Carpenter's message of "Fri, 16 Dec 2016 12:35:39 +0300") Sender: kernel-janitors-owner@vger.kernel.org To: Dan Carpenter Cc: Adaptec OEM Raid Solutions , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: linux-scsi@vger.kernel.org >>>>> "Dan" == Dan Carpenter writes: Dan> There are two places where adpt_i2o_online_hba() is called. Both Dan> callers call adpt_i2o_delete_hba(pHba) if adpt_i2o_online_hba() Dan> fails and since we also free it here that causes a double free bug. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering