From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable check Date: Thu, 30 Jul 2015 13:23:32 -0400 Message-ID: References: <1438091666-18113-1-git-send-email-tomas.winkler@intel.com> <1438091666-18113-5-git-send-email-tomas.winkler@intel.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:32844 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751910AbbG3RXl (ORCPT ); Thu, 30 Jul 2015 13:23:41 -0400 In-Reply-To: <1438091666-18113-5-git-send-email-tomas.winkler@intel.com> (Tomas Winkler's message of "Tue, 28 Jul 2015 16:54:24 +0300") Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Tomas Winkler Cc: James Bottomley , Christoph Hellwig , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Douglas Gilbert >>>>> "Tomas" == Tomas Winkler writes: Tomas> The function should never be called with cmnd NULL so put a fat Tomas> WARN there. Fix also smatch wraning: schedule_resp() warn: Tomas> variable dereferenced before check 'cmnd' Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering