From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Elliott, Robert (Server Storage)" <Elliott@hp.com>
Cc: "dgilbert@interlog.com" <dgilbert@interlog.com>,
SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v2] scsi_debug: support scsi-mq, queues and locks
Date: Tue, 15 Jul 2014 13:48:44 -0400 [thread overview]
Message-ID: <yq11ttmv7gj.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <94D0CD8314A33A4D9D801C0FE68B402958BA045E@G9W0745.americas.hpqcorp.net> (Robert Elliott's message of "Sun, 13 Jul 2014 22:55:19 +0000")
>>>>> "Rob" == Elliott, Robert (Server Storage) <Elliott@hp.com> writes:
Rob,
Rob> When resp_unmap is the caller, though, there is no guarantee that
Rob> the data will change.
Rob> Maybe another modparam should be included to cause the driver to
Rob> purposely ignore unmap requests? That might help more people
Rob> realize the danger in these commands.
I don't really have a problem with an additional option.
I also think it's important to emphasize that the purpose of the LBP
support in scsi_debug is to test the block and SCSI layer code. The same
is true for the T10 PI support. I see scsi_debug as being a simple test
vehicle rather than a comprehensive and realistic SCSI target. We have
the target subsystem for that.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2014-07-15 17:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 13:30 [PATCH v2] scsi_debug: support scsi-mq, queues and locks Douglas Gilbert
2014-07-10 11:02 ` Christoph Hellwig
2014-07-13 22:55 ` Elliott, Robert (Server Storage)
2014-07-14 14:00 ` Douglas Gilbert
2014-07-15 17:48 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq11ttmv7gj.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=Elliott@hp.com \
--cc=dgilbert@interlog.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox