Re: [PATCH v2 0/3] scsi: aic7xxx: fix some problem of return value

Dan Carpenter
2023-12-05T08:15:05Z

On Tue, Dec 05, 2023 at 11:33:36AM +0800, Su Hui wrote:
> On 2023/12/1 15:53, Dan Carpenter wrote:
> > On Fri, Dec 01, 2023 at 10:59:53AM +0800, Su Hui wrote:
> > > v2:
> > > - fix some problems and split v1 patch into this patch set.(Thanks to
> > > Dan)
> > >
> > > v1:
> > > - https://lore.kernel.org/all/20231130024122.1193324-1-suhui@nfschina.com/
> > >
> > Would have been better with Fixes tags probably. Otherwise, it looks
> > good to me.
>
> Hi, Dan
>
> Sorry for the late reply.
>
> I'm not sure if it's worth to add Fixes tags.
> These codes are very old which come from "Linux-2.6.12-rc2".

I know some people use Fixes tags to point to Linux-2.6.12-rc2 but
other people don't like it... Or they didn't like it back in the day,
I'm not sure now.

> It's seems like a cleanup or improvement.

It's definitely a Fix. It affects runtime.

>
> Umm, should I send v3 patches to add Fixes tags?

I don't really care, I guess. Probably yes? Not a lot of people use
aic7xxx these days so from a practical perspective it's not super
important either way.

regards,
dan carpenter