Re: [PATCH v5 14/52] advansys: Use scsi_cmd_to_rq() instead of scsi_cmnd.request

Matthew Wilcox
2021-08-13T02:20:47Z

On Wed, Aug 11, 2021 at 10:58:10PM -0400, Martin K. Petersen wrote:
> Thoughts?

Seems a bit verbose to me.

> - qc = ata_qc_new_init(dev, scsi_cmd_to_rq(cmd)->tag);
> + qc = ata_qc_new_init(dev, scsi_cmd_to_tag(cmd));

qc = ata_qc_new_init(dev, scmd_tag(cmd));

would fit with scmd_printk(), scmd_id(), scmd_channel(), etc.