From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Ewan D. Milne" <emilne@redhat.com>
Cc: Maurizio Lombardi <mlombard@redhat.com>,
linux-scsi@vger.kernel.org, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com
Subject: Re: [PATCH] ses: fix error message in ses_intf_add()
Date: Wed, 17 May 2017 20:18:21 -0400 [thread overview]
Message-ID: <yq137c381bm.fsf@oracle.com> (raw)
In-Reply-To: <1495028486.3629.10.camel@localhost.localdomain> (Ewan D. Milne's message of "Wed, 17 May 2017 09:41:26 -0400")
Ewan,
> This looks OK but I think we should consider suppressing these
> messages. There are a lot of devices that return page 0 instead of
> the correct page, we should either say something like "enclosure
> services not supported", or else work with what we get instead of
> logging a message on every device probe that make it sound like
> the device is failing.
I agree.
> I've received several complaints about this.
Me too. There appears to be a ton of bad devices out there.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-05-18 0:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 13:00 [PATCH] ses: fix error message in ses_intf_add() Maurizio Lombardi
2017-05-17 13:41 ` Ewan D. Milne
2017-05-18 0:18 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq137c381bm.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=emilne@redhat.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mlombard@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox