From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [RESEND][PATCH 07/10][SCSI]mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support Date: Fri, 25 Jul 2014 15:43:16 -0400 Message-ID: References: <20140625103445.GA12943@avagotech.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (Sreekanth Reddy's message of "Fri, 25 Jul 2014 18:27:08 +0530") Sender: linux-kernel-owner@vger.kernel.org To: Sreekanth Reddy Cc: "Martin K. Petersen" , jejb@kernel.org, "James E.J. Bottomley" , linux-scsi@vger.kernel.org, Sathya Prakash , Nagalakshmi Nandigama , linux-kernel@vger.kernel.org, Christoph Hellwig List-Id: linux-scsi@vger.kernel.org >>>>> "Sreekanth" == Sreekanth Reddy writes: Sreekanth, Sreekanth> Following are the changes that I have done in this patch over Sreekanth> the first RDPQ support patch, Please, please do the function moves in a different patch. Or use a simple prototype declaration like I did to avoid moving the code around in the first place. Sreekanth> 2. Set pci_set_consistent_dma_mask() to Sreekanth> DMA_BIT_MASK(32). still I am analysing whether this change Sreekanth> may affect on any other things or not? I think you're done allocating things by the time this is called. But to be sure you can call _base_config_dma_addressing() after you're done with the RDPQ allocations (or rearrange the code so you allocate RDPQ before the DMA mask is upped in general). -- Martin K. Petersen Oracle Linux Engineering