From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Justin Stitt <justinstitt@google.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
llvm@lists.linux.dev, martin.petersen@oracle.com,
mgurtovoy@nvidia.com, michael.christie@oracle.com,
mingzhe.zou@easystack.cn, nathan@kernel.org,
ndesaulniers@google.com, target-devel@vger.kernel.org,
trix@redhat.com
Subject: Re: [PATCH v2] target: iscsi: fix clang -Wformat warnings
Date: Mon, 18 Jul 2022 23:00:38 -0400 [thread overview]
Message-ID: <yq14jzdq01g.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20220718180421.49697-1-justinstitt@google.com> (Justin Stitt's message of "Mon, 18 Jul 2022 11:04:21 -0700")
Justin,
> For all warnings, the format specifier is `%hu` which describes an
> unsigned short. The resulting type of atomic_read is an int. The
> proposed fix is to listen to Clang and swap the format specifier.
Applied to 5.20/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-07-19 3:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 21:14 [PATCH] target: iscsi: fix clang -Wformat warning Justin Stitt
2022-07-08 23:42 ` Nick Desaulniers
2022-07-18 18:04 ` [PATCH v2] target: iscsi: fix clang -Wformat warnings Justin Stitt
2022-07-18 20:55 ` Nick Desaulniers
2022-07-18 21:35 ` Chaitanya Kulkarni
2022-07-19 3:00 ` Martin K. Petersen [this message]
2022-07-27 3:15 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq14jzdq01g.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mgurtovoy@nvidia.com \
--cc=michael.christie@oracle.com \
--cc=mingzhe.zou@easystack.cn \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=target-devel@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox