* [PATCH] scsi: ufs: convert sysfs sprintf/snprintf family to sysfs_emit
@ 2021-02-03 7:39 Jiapeng Chong
2021-02-03 7:49 ` Avri Altman
2021-02-09 3:12 ` Martin K. Petersen
0 siblings, 2 replies; 6+ messages in thread
From: Jiapeng Chong @ 2021-02-03 7:39 UTC (permalink / raw)
To: alim.akhtar
Cc: avri.altman, jejb, martin.petersen, linux-scsi, linux-kernel,
Jiapeng Chong
Fix the following coccicheck warning:
./drivers/scsi/ufs/ufshcd.c:1838:8-16: WARNING: use scnprintf or
sprintf.
./drivers/scsi/ufs/ufshcd.c:1815:8-16: WARNING: use scnprintf or
sprintf.
./drivers/scsi/ufs/ufshcd.c:1525:8-16: WARNING: use scnprintf or
sprintf.
Reported-by: Abaci Robot<abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/scsi/ufs/ufshcd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index fb32d12..292cb63 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -1522,7 +1522,7 @@ static ssize_t ufshcd_clkscale_enable_show(struct device *dev,
{
struct ufs_hba *hba = dev_get_drvdata(dev);
- return snprintf(buf, PAGE_SIZE, "%d\n", hba->clk_scaling.is_allowed);
+ return sysfs_emit(buf, "%d\n", hba->clk_scaling.is_allowed);
}
static ssize_t ufshcd_clkscale_enable_store(struct device *dev,
@@ -1812,7 +1812,7 @@ static ssize_t ufshcd_clkgate_delay_show(struct device *dev,
{
struct ufs_hba *hba = dev_get_drvdata(dev);
- return snprintf(buf, PAGE_SIZE, "%lu\n", hba->clk_gating.delay_ms);
+ return sysfs_emit(buf, "%lu\n", hba->clk_gating.delay_ms);
}
static ssize_t ufshcd_clkgate_delay_store(struct device *dev,
@@ -1835,7 +1835,7 @@ static ssize_t ufshcd_clkgate_enable_show(struct device *dev,
{
struct ufs_hba *hba = dev_get_drvdata(dev);
- return snprintf(buf, PAGE_SIZE, "%d\n", hba->clk_gating.is_enabled);
+ return sysfs_emit(buf, "%d\n", hba->clk_gating.is_enabled);
}
static ssize_t ufshcd_clkgate_enable_store(struct device *dev,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] scsi: ufs: convert sysfs sprintf/snprintf family to sysfs_emit
2021-02-03 7:39 [PATCH] scsi: ufs: convert sysfs sprintf/snprintf family to sysfs_emit Jiapeng Chong
@ 2021-02-03 7:49 ` Avri Altman
2021-02-09 3:12 ` Martin K. Petersen
1 sibling, 0 replies; 6+ messages in thread
From: Avri Altman @ 2021-02-03 7:49 UTC (permalink / raw)
To: Jiapeng Chong, alim.akhtar@samsung.com
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
>
> Fix the following coccicheck warning:
>
> ./drivers/scsi/ufs/ufshcd.c:1838:8-16: WARNING: use scnprintf or
> sprintf.
>
> ./drivers/scsi/ufs/ufshcd.c:1815:8-16: WARNING: use scnprintf or
> sprintf.
>
> ./drivers/scsi/ufs/ufshcd.c:1525:8-16: WARNING: use scnprintf or
> sprintf.
>
> Reported-by: Abaci Robot<abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: ufs: convert sysfs sprintf/snprintf family to sysfs_emit
2021-02-03 7:39 [PATCH] scsi: ufs: convert sysfs sprintf/snprintf family to sysfs_emit Jiapeng Chong
2021-02-03 7:49 ` Avri Altman
@ 2021-02-09 3:12 ` Martin K. Petersen
1 sibling, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2021-02-09 3:12 UTC (permalink / raw)
To: Jiapeng Chong
Cc: alim.akhtar, avri.altman, jejb, martin.petersen, linux-scsi,
linux-kernel
Jiapeng,
> Fix the following coccicheck warning:
>
> ./drivers/scsi/ufs/ufshcd.c:1838:8-16: WARNING: use scnprintf or
> sprintf.
>
> ./drivers/scsi/ufs/ufshcd.c:1815:8-16: WARNING: use scnprintf or
> sprintf.
>
> ./drivers/scsi/ufs/ufshcd.c:1525:8-16: WARNING: use scnprintf or
> sprintf.
Does not apply to 5.12/scsi-staging. Please rebase.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] scsi: ufs: convert sysfs sprintf/snprintf family to sysfs_emit
@ 2021-03-02 6:08 Jiapeng Chong
2021-03-02 7:04 ` Avri Altman
2021-03-04 4:16 ` Martin K. Petersen
0 siblings, 2 replies; 6+ messages in thread
From: Jiapeng Chong @ 2021-03-02 6:08 UTC (permalink / raw)
To: alim.akhtar
Cc: avri.altman, jejb, martin.petersen, linux-scsi, linux-kernel,
Jiapeng Chong
Fix the following coccicheck warning:
./drivers/scsi/ufs/ufshcd.c:1538:8-16: WARNING: use scnprintf or
sprintf.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 7716175..7fb94d7 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -1535,7 +1535,7 @@ static ssize_t ufshcd_clkscale_enable_show(struct device *dev,
{
struct ufs_hba *hba = dev_get_drvdata(dev);
- return snprintf(buf, PAGE_SIZE, "%d\n", hba->clk_scaling.is_enabled);
+ return sysfs_emit(buf, "%d\n", hba->clk_scaling.is_enabled);
}
static ssize_t ufshcd_clkscale_enable_store(struct device *dev,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] scsi: ufs: convert sysfs sprintf/snprintf family to sysfs_emit
2021-03-02 6:08 Jiapeng Chong
@ 2021-03-02 7:04 ` Avri Altman
2021-03-04 4:16 ` Martin K. Petersen
1 sibling, 0 replies; 6+ messages in thread
From: Avri Altman @ 2021-03-02 7:04 UTC (permalink / raw)
To: Jiapeng Chong, alim.akhtar@samsung.com
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
> Fix the following coccicheck warning:
>
> ./drivers/scsi/ufs/ufshcd.c:1538:8-16: WARNING: use scnprintf or
> sprintf.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 7716175..7fb94d7 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1535,7 +1535,7 @@ static ssize_t ufshcd_clkscale_enable_show(struct
> device *dev,
> {
> struct ufs_hba *hba = dev_get_drvdata(dev);
>
> - return snprintf(buf, PAGE_SIZE, "%d\n", hba->clk_scaling.is_enabled);
> + return sysfs_emit(buf, "%d\n", hba->clk_scaling.is_enabled);
> }
>
> static ssize_t ufshcd_clkscale_enable_store(struct device *dev,
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: ufs: convert sysfs sprintf/snprintf family to sysfs_emit
2021-03-02 6:08 Jiapeng Chong
2021-03-02 7:04 ` Avri Altman
@ 2021-03-04 4:16 ` Martin K. Petersen
1 sibling, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2021-03-04 4:16 UTC (permalink / raw)
To: alim.akhtar, Jiapeng Chong
Cc: Martin K . Petersen, linux-kernel, jejb, linux-scsi, avri.altman
On Tue, 2 Mar 2021 14:08:18 +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warning:
>
> ./drivers/scsi/ufs/ufshcd.c:1538:8-16: WARNING: use scnprintf or
> sprintf.
Applied to 5.12/scsi-fixes, thanks!
[1/1] scsi: ufs: convert sysfs sprintf/snprintf family to sysfs_emit
https://git.kernel.org/mkp/scsi/c/7393d296d6f2
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-04 4:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-03 7:39 [PATCH] scsi: ufs: convert sysfs sprintf/snprintf family to sysfs_emit Jiapeng Chong
2021-02-03 7:49 ` Avri Altman
2021-02-09 3:12 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2021-03-02 6:08 Jiapeng Chong
2021-03-02 7:04 ` Avri Altman
2021-03-04 4:16 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox