* [PATCH] scsi: qla4xxx: Delete unneeded variable 'status' in qla4xxx_process_ddb_changed
@ 2020-09-16 2:27 Ye Bin
2020-10-03 1:58 ` Martin K. Petersen
2020-10-07 3:48 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Ye Bin @ 2020-09-16 2:27 UTC (permalink / raw)
To: njavali, mrangankar, linux-scsi; +Cc: Ye Bin, Hulk Robot
Fixes coccicheck warning:
drivers/scsi/qla4xxx/ql4_init.c:1173:5-11: Unneeded variable: "status". Return "QLA_ERROR" on line 1195
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
drivers/scsi/qla4xxx/ql4_init.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/qla4xxx/ql4_init.c b/drivers/scsi/qla4xxx/ql4_init.c
index 4a7ef971a387..6444f4bb61b3 100644
--- a/drivers/scsi/qla4xxx/ql4_init.c
+++ b/drivers/scsi/qla4xxx/ql4_init.c
@@ -1170,7 +1170,6 @@ int qla4xxx_process_ddb_changed(struct scsi_qla_host *ha,
uint32_t state, uint32_t conn_err)
{
struct ddb_entry *ddb_entry;
- int status = QLA_ERROR;
/* check for out of range index */
if (fw_ddb_index >= MAX_DDB_ENTRIES)
@@ -1192,7 +1191,7 @@ int qla4xxx_process_ddb_changed(struct scsi_qla_host *ha,
ddb_entry->ddb_change(ha, fw_ddb_index, ddb_entry, state);
exit_ddb_event:
- return status;
+ return QLA_ERROR;
}
/**
--
2.25.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qla4xxx: Delete unneeded variable 'status' in qla4xxx_process_ddb_changed
2020-09-16 2:27 [PATCH] scsi: qla4xxx: Delete unneeded variable 'status' in qla4xxx_process_ddb_changed Ye Bin
@ 2020-10-03 1:58 ` Martin K. Petersen
2020-10-07 3:48 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-10-03 1:58 UTC (permalink / raw)
To: Ye Bin; +Cc: njavali, mrangankar, linux-scsi, Hulk Robot
Ye,
> Fixes coccicheck warning:
> drivers/scsi/qla4xxx/ql4_init.c:1173:5-11: Unneeded variable: "status". Return "QLA_ERROR" on line 1195
Applied to 5.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qla4xxx: Delete unneeded variable 'status' in qla4xxx_process_ddb_changed
2020-09-16 2:27 [PATCH] scsi: qla4xxx: Delete unneeded variable 'status' in qla4xxx_process_ddb_changed Ye Bin
2020-10-03 1:58 ` Martin K. Petersen
@ 2020-10-07 3:48 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-10-07 3:48 UTC (permalink / raw)
To: njavali, Ye Bin, linux-scsi, mrangankar; +Cc: Martin K . Petersen, Hulk Robot
On Wed, 16 Sep 2020 10:27:49 +0800, Ye Bin wrote:
> Fixes coccicheck warning:
> drivers/scsi/qla4xxx/ql4_init.c:1173:5-11: Unneeded variable: "status". Return "QLA_ERROR" on line 1195
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: qla4xxx: Delete unneeded variable 'status' in qla4xxx_process_ddb_changed
https://git.kernel.org/mkp/scsi/c/121432e87093
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-07 3:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-16 2:27 [PATCH] scsi: qla4xxx: Delete unneeded variable 'status' in qla4xxx_process_ddb_changed Ye Bin
2020-10-03 1:58 ` Martin K. Petersen
2020-10-07 3:48 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox