* [PATCH] scsi: core: Add DID_ALLOC_FAILURE and DID_MEDIUM_ERROR to hostbyte_table
@ 2020-04-01 3:55 Nikhil Kshirsagar
2020-04-01 9:06 ` Christoph Hellwig
2020-04-02 2:03 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Nikhil Kshirsagar @ 2020-04-01 3:55 UTC (permalink / raw)
To: martin.petersen
Cc: Christoph Hellwig, James Bottomley, linux-scsi, Hannes Reinecke
Since DID_ALLOC_FAILURE and DID_MEDIUM_ERROR are missing from the
hostbyte_table, scsi debug logging prints their numeric values only.
Adding them to the hostbyte_table to allow the scsi debug log to print
those as strings.
Signed-off-by: Nikhil Kshirsagar <nkshirsa@redhat.com>
---
diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.c
index d4c2a2e4c5d4..84d73f57292b 100644
--- a/drivers/scsi/constants.c
+++ b/drivers/scsi/constants.c
@@ -404,7 +404,7 @@ static const char * const hostbyte_table[]={
"DID_ABORT", "DID_PARITY", "DID_ERROR", "DID_RESET", "DID_BAD_INTR",
"DID_PASSTHROUGH", "DID_SOFT_ERROR", "DID_IMM_RETRY", "DID_REQUEUE",
"DID_TRANSPORT_DISRUPTED", "DID_TRANSPORT_FAILFAST", "DID_TARGET_FAILURE",
-"DID_NEXUS_FAILURE" };
+"DID_NEXUS_FAILURE", "DID_ALLOC_FAILURE", "DID_MEDIUM_ERROR" };
static const char * const driverbyte_table[]={
"DRIVER_OK", "DRIVER_BUSY", "DRIVER_SOFT", "DRIVER_MEDIA", "DRIVER_ERROR",
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: core: Add DID_ALLOC_FAILURE and DID_MEDIUM_ERROR to hostbyte_table
2020-04-01 3:55 [PATCH] scsi: core: Add DID_ALLOC_FAILURE and DID_MEDIUM_ERROR to hostbyte_table Nikhil Kshirsagar
@ 2020-04-01 9:06 ` Christoph Hellwig
2020-04-02 2:03 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2020-04-01 9:06 UTC (permalink / raw)
To: Nikhil Kshirsagar
Cc: martin.petersen, Christoph Hellwig, James Bottomley, linux-scsi,
Hannes Reinecke
On Wed, Apr 01, 2020 at 09:25:00AM +0530, Nikhil Kshirsagar wrote:
> Since DID_ALLOC_FAILURE and DID_MEDIUM_ERROR are missing from the
> hostbyte_table, scsi debug logging prints their numeric values only.
> Adding them to the hostbyte_table to allow the scsi debug log to print
> those as strings.
>
> Signed-off-by: Nikhil Kshirsagar <nkshirsa@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: core: Add DID_ALLOC_FAILURE and DID_MEDIUM_ERROR to hostbyte_table
2020-04-01 3:55 [PATCH] scsi: core: Add DID_ALLOC_FAILURE and DID_MEDIUM_ERROR to hostbyte_table Nikhil Kshirsagar
2020-04-01 9:06 ` Christoph Hellwig
@ 2020-04-02 2:03 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-04-02 2:03 UTC (permalink / raw)
To: Nikhil Kshirsagar
Cc: martin.petersen, Christoph Hellwig, James Bottomley, linux-scsi,
Hannes Reinecke
Nikhil,
> Since DID_ALLOC_FAILURE and DID_MEDIUM_ERROR are missing from the
> hostbyte_table, scsi debug logging prints their numeric values only.
> Adding them to the hostbyte_table to allow the scsi debug log to print
> those as strings.
Applied to 5.7/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-02 2:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-01 3:55 [PATCH] scsi: core: Add DID_ALLOC_FAILURE and DID_MEDIUM_ERROR to hostbyte_table Nikhil Kshirsagar
2020-04-01 9:06 ` Christoph Hellwig
2020-04-02 2:03 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).