From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH 1/2] scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade Date: Thu, 20 Jun 2019 16:32:38 -0400 Message-ID: References: <20190618013146.21961-1-marcos.souza.org@gmail.com> <20190618013146.21961-2-marcos.souza.org@gmail.com> <20190619094540.GA26980@continental> <20190619120346.GC26980@continental> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20190619120346.GC26980@continental> (Marcos Paulo de Souza's message of "Wed, 19 Jun 2019 09:03:52 -0300") Sender: linux-kernel-owner@vger.kernel.org To: Marcos Paulo de Souza Cc: "Martin K. Petersen" , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, "James E.J. Bottomley" List-Id: linux-scsi@vger.kernel.org Marcos, > My first idea was to add a vendor:product mapping at SCSI layer, but > so far I haven't found one, so I added the model/vendor found by > INQUIRY. Would it be better to check for prod:vendor (as values, > instead of the description)? Your patch is functionally fine. I'm just trying to establish how risky it is for me to pick it up. -- Martin K. Petersen Oracle Linux Engineering