From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: damien.lemoal@wdc.com, linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Bart Van Assche <Bart.VanAssche@sandisk.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v2 3/7] sd: Cleanup sd_done sense data handling
Date: Mon, 24 Apr 2017 19:11:23 -0400 [thread overview]
Message-ID: <yq14lxdh04k.fsf@oracle.com> (raw)
In-Reply-To: <20170424153535.GE895@lst.de> (Christoph Hellwig's message of "Mon, 24 Apr 2017 17:35:35 +0200")
Christoph,
> Use a switch for the sense key, and remove two pointless variables
> that are only used once.
> - if (unmap)
The rationale behind the unmap variable was clarity and avoiding magic
values.
I'm OK with this, however:
> + if (SCpnt->cmnd[1] & 8) { /* UNMAP */
So I committed with that change.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-04-24 23:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 7:51 [PATCH v2 0/7] scsi: sd/sd_zbc cleanup and improvements damien.lemoal
2017-04-24 7:51 ` [PATCH v2 1/7] sd: Fix functions description damien.lemoal
2017-04-24 15:30 ` Christoph Hellwig
2017-04-24 7:51 ` [PATCH v2 2/7] sd: Improve sd_completed_bytes damien.lemoal
2017-04-24 15:31 ` Christoph Hellwig
2017-04-24 7:51 ` [PATCH v2 3/7] sd: Cleanup sd_done sense data handling damien.lemoal
2017-04-24 15:35 ` Christoph Hellwig
2017-04-24 23:11 ` Martin K. Petersen [this message]
2017-04-25 1:54 ` Damien Le Moal
2017-04-25 17:03 ` Martin K. Petersen
2017-04-24 7:51 ` [PATCH v2 4/7] scsi: Improve scsi_get_sense_info_fld damien.lemoal
2017-04-24 15:36 ` Christoph Hellwig
2017-04-24 7:51 ` [PATCH v2 5/7] sd_zbc: Rename sd_zbc_setup_write_cmnd damien.lemoal
2017-04-24 15:36 ` Christoph Hellwig
2017-04-24 7:51 ` [PATCH v2 6/7] sd_zbc: Remove superfluous assignments damien.lemoal
2017-04-24 15:37 ` Christoph Hellwig
2017-04-24 7:51 ` [PATCH v2 7/7] sd_zbc: Do not write lock zones for reset damien.lemoal
2017-04-24 15:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq14lxdh04k.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=damien.lemoal@wdc.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox