From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Varun Prakash <varun@chelsio.com>
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
indranil@chelsio.com
Subject: Re: [PATCH] scsi: libcxgbi: simplify task->hdr allocation for mgmt cmds
Date: Wed, 11 Oct 2017 14:28:32 -0400 [thread overview]
Message-ID: <yq160blfsj3.fsf@oracle.com> (raw)
In-Reply-To: <1507730601-6702-1-git-send-email-varun@chelsio.com> (Varun Prakash's message of "Wed, 11 Oct 2017 19:33:21 +0530")
Varun,
> In case of mgmt cmds task->hdr is dereferenced after transmitting the
> pdu in iscsi_tcp_task_xmit() to handle this case current code
> increments the Tx skb reference count and frees the skb in
> cxgbi_cleanup_task(), in some error cases this results in skb leak.
>
> To fix this in case of mgmt cmds allocate a separate buffer for iSCSI
> hdr and free this buffer in cxgbi_cleanup_task().
Applied to 4.15/scsi-queue. Thanks again!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-10-11 18:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 14:03 [PATCH] scsi: libcxgbi: simplify task->hdr allocation for mgmt cmds Varun Prakash
2017-10-11 18:28 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq160blfsj3.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=indranil@chelsio.com \
--cc=linux-scsi@vger.kernel.org \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).