* [PATCH] scsi: sd: remove duplicated setting of gd->minors
@ 2017-08-18 6:49 weiping zhang
2017-08-24 11:57 ` weiping zhang
2017-08-25 21:28 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: weiping zhang @ 2017-08-18 6:49 UTC (permalink / raw)
To: martin.petersen, jejb; +Cc: linux-scsi
gd->minors has been set when call alloc_disk() in sd_probe.
Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
---
drivers/scsi/sd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index bea36ad..c18ca7a 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -3223,7 +3223,6 @@ static void sd_probe_async(void *data, async_cookie_t cookie)
gd->major = sd_major((index & 0xf0) >> 4);
gd->first_minor = ((index & 0xf) << 4) | (index & 0xfff00);
- gd->minors = SD_MINORS;
gd->fops = &sd_fops;
gd->private_data = &sdkp->driver;
--
2.9.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: sd: remove duplicated setting of gd->minors
2017-08-18 6:49 [PATCH] scsi: sd: remove duplicated setting of gd->minors weiping zhang
@ 2017-08-24 11:57 ` weiping zhang
2017-08-25 21:28 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: weiping zhang @ 2017-08-24 11:57 UTC (permalink / raw)
To: martin.petersen, jejb; +Cc: linux-scsi
On Fri, Aug 18, 2017 at 02:49:30PM +0800, weiping zhang wrote:
> gd->minors has been set when call alloc_disk() in sd_probe.
>
> Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
> ---
> drivers/scsi/sd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index bea36ad..c18ca7a 100644
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -3223,7 +3223,6 @@ static void sd_probe_async(void *data, async_cookie_t cookie)
>
> gd->major = sd_major((index & 0xf0) >> 4);
> gd->first_minor = ((index & 0xf) << 4) | (index & 0xfff00);
> - gd->minors = SD_MINORS;
>
> gd->fops = &sd_fops;
> gd->private_data = &sdkp->driver;
> --
> 2.9.4
>
Hi Martin,
would you please look into this misc patch ?
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: sd: remove duplicated setting of gd->minors
2017-08-18 6:49 [PATCH] scsi: sd: remove duplicated setting of gd->minors weiping zhang
2017-08-24 11:57 ` weiping zhang
@ 2017-08-25 21:28 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2017-08-25 21:28 UTC (permalink / raw)
To: weiping zhang; +Cc: martin.petersen, jejb, linux-scsi
weiping,
> gd->minors has been set when call alloc_disk() in sd_probe.
Applied to 4.14/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-25 21:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-18 6:49 [PATCH] scsi: sd: remove duplicated setting of gd->minors weiping zhang
2017-08-24 11:57 ` weiping zhang
2017-08-25 21:28 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).