From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: tom.ty89@gmail.com
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] sd: read unmap block limits even if lbpme=0
Date: Wed, 16 Aug 2017 22:11:46 -0400 [thread overview]
Message-ID: <yq160dnndst.fsf@oracle.com> (raw)
In-Reply-To: <59921282.c3341c0a.a8437.1b70@mx.google.com> (tom's message of "Tue, 15 Aug 2017 05:13:26 +0800")
Tom,
> Some devices may not be decent enough to report lbpme bit properly
> even when they do support unmap and report relevant information in the
> block limits and logical block provisioning VPDs properly (Namely,
> ASMedia ASM1351, a UAS-SATA bridge). One of the reasons is, lbpme=1 is
> not a requirement for "DeleteNotify" in Windows to be activated:
I have to confess I'm wary of interpreting values reported by a device
that messes up setting the single bit flag that enables the feature.
Before I entertain taking your patch I'd like to take a closer look to
make sure everything is gated by sdkp->lbpme.
However, instead of relying on UNMAP, does this bridge support WRITE
SAME with the UNMAP bit? Because in that case you should be able to set
provisioning_mode to WS10 or WS16 and then adjust max_write_same_blocks.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-08-17 2:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 21:13 [PATCH] sd: read unmap block limits even if lbpme=0 tom.ty89
2017-08-17 2:11 ` Martin K. Petersen [this message]
2017-08-17 15:10 ` Tom Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq160dnndst.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=tom.ty89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox