From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Douglas Gilbert <dgilbert@interlog.com>
Subject: Re: [PATCH] scsi: PC partition tables are little endian
Date: Fri, 17 Oct 2014 19:47:25 -0400 [thread overview]
Message-ID: <yq161fi2r8y.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20141017131349.GB16538@infradead.org> (Christoph Hellwig's message of "Fri, 17 Oct 2014 06:13:50 -0700")
>>>>> "Christoph" == Christoph Hellwig <hch@infradead.org> writes:
>> As sparse correctly pointed out scsi_partsize should use
>> get_unaligned_le32 to read PC partition tables from disk, as they are
>> little endian.
>>
>> The result of this bug is that we returned incorrect geometries on
>> big endian systems when using the scsicam variant. Which probably
>> doesn't matter as only old x86 systems every cared about the
>> geometry.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2014-10-17 23:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 18:31 [PATCH] scsi: PC partition tables are little endian Christoph Hellwig
2014-10-17 13:13 ` Christoph Hellwig
2014-10-17 15:24 ` Hannes Reinecke
2014-10-17 23:47 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq161fi2r8y.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=dgilbert@interlog.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox