* [PATCH] mpt2sas: Fix missing reference tag seed with Type 2 devices
@ 2010-10-21 18:19 Martin K. Petersen
0 siblings, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2010-10-21 18:19 UTC (permalink / raw)
To: Eric.Moore, James.Bottomley; +Cc: linux-scsi
Eric,
I just pulled 2.6.36 and discovered Type 2 devices were not
working. Turns out you tweaked my mpt2sas Type 2 patch a bit before
submitting it to James. Your change left the initial reference tag unset
in the Type 2 case, causing all I/O to fail. The following patch fixes
things up.
[PATCH] mpt2sas: Fix missing reference tag seed with Type 2 devices
Ensure that the initial reference tag is passed on to the HBA firmware
for DIF Type 2 devices.
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
index 16e99b6..f423fe9 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
@@ -3230,6 +3230,7 @@ _scsih_setup_eedp(struct scsi_cmnd *scmd, Mpi2SCSIIORequest_t *mpi_request)
switch (prot_type) {
case SCSI_PROT_DIF_TYPE1:
+ case SCSI_PROT_DIF_TYPE2:
/*
* enable ref/guard checking
@@ -3242,13 +3243,6 @@ _scsih_setup_eedp(struct scsi_cmnd *scmd, Mpi2SCSIIORequest_t *mpi_request)
cpu_to_be32(scsi_get_lba(scmd));
break;
- case SCSI_PROT_DIF_TYPE2:
-
- eedp_flags |= MPI2_SCSIIO_EEDPFLAGS_INC_PRI_REFTAG |
- MPI2_SCSIIO_EEDPFLAGS_CHECK_REFTAG |
- MPI2_SCSIIO_EEDPFLAGS_CHECK_GUARD;
- break;
-
case SCSI_PROT_DIF_TYPE3:
/*
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] mpt2sas: Fix missing reference tag seed with Type 2 devices
@ 2011-03-08 6:59 Martin K. Petersen
2011-04-11 5:29 ` Desai, Kashyap
0 siblings, 1 reply; 3+ messages in thread
From: Martin K. Petersen @ 2011-03-08 6:59 UTC (permalink / raw)
To: linux-scsi, James.Bottomley, Kashyap.Desai, Eric.Moore
Ensure that the initial reference tag is passed on to the HBA firmware
for DIF Type 2 devices.
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
index 16e99b6..f423fe9 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
@@ -3230,6 +3230,7 @@ _scsih_setup_eedp(struct scsi_cmnd *scmd, Mpi2SCSIIORequest_t *mpi_request)
switch (prot_type) {
case SCSI_PROT_DIF_TYPE1:
+ case SCSI_PROT_DIF_TYPE2:
/*
* enable ref/guard checking
@@ -3242,13 +3243,6 @@ _scsih_setup_eedp(struct scsi_cmnd *scmd, Mpi2SCSIIORequest_t *mpi_request)
cpu_to_be32(scsi_get_lba(scmd));
break;
- case SCSI_PROT_DIF_TYPE2:
-
- eedp_flags |= MPI2_SCSIIO_EEDPFLAGS_INC_PRI_REFTAG |
- MPI2_SCSIIO_EEDPFLAGS_CHECK_REFTAG |
- MPI2_SCSIIO_EEDPFLAGS_CHECK_GUARD;
- break;
-
case SCSI_PROT_DIF_TYPE3:
/*
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] mpt2sas: Fix missing reference tag seed with Type 2 devices
2011-03-08 6:59 [PATCH] mpt2sas: Fix missing reference tag seed with Type 2 devices Martin K. Petersen
@ 2011-04-11 5:29 ` Desai, Kashyap
0 siblings, 0 replies; 3+ messages in thread
From: Desai, Kashyap @ 2011-04-11 5:29 UTC (permalink / raw)
To: Martin K. Petersen, linux-scsi@vger.kernel.org,
James.Bottomley@hansenpartnership.com
James,
We discuss this patch internally and found as valid candidate to be ACKed.
Please consider this patch as an ACKed.
Thanks, Kashyap
> -----Original Message-----
> From: Martin K. Petersen [mailto:martin.petersen@oracle.com]
> Sent: Tuesday, March 08, 2011 12:30 PM
> To: linux-scsi@vger.kernel.org; James.Bottomley@hansenpartnership.com;
> Desai, Kashyap; Moore, Eric
> Subject: [PATCH] mpt2sas: Fix missing reference tag seed with Type 2
> devices
>
>
> Ensure that the initial reference tag is passed on to the HBA firmware
> for DIF Type 2 devices.
>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
>
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> index 16e99b6..f423fe9 100644
> --- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> +++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> @@ -3230,6 +3230,7 @@ _scsih_setup_eedp(struct scsi_cmnd *scmd,
> Mpi2SCSIIORequest_t *mpi_request)
>
> switch (prot_type) {
> case SCSI_PROT_DIF_TYPE1:
> + case SCSI_PROT_DIF_TYPE2:
>
> /*
> * enable ref/guard checking
> @@ -3242,13 +3243,6 @@ _scsih_setup_eedp(struct scsi_cmnd *scmd,
> Mpi2SCSIIORequest_t *mpi_request)
> cpu_to_be32(scsi_get_lba(scmd));
> break;
>
> - case SCSI_PROT_DIF_TYPE2:
> -
> - eedp_flags |= MPI2_SCSIIO_EEDPFLAGS_INC_PRI_REFTAG |
> - MPI2_SCSIIO_EEDPFLAGS_CHECK_REFTAG |
> - MPI2_SCSIIO_EEDPFLAGS_CHECK_GUARD;
> - break;
> -
> case SCSI_PROT_DIF_TYPE3:
>
> /*
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-11 5:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-08 6:59 [PATCH] mpt2sas: Fix missing reference tag seed with Type 2 devices Martin K. Petersen
2011-04-11 5:29 ` Desai, Kashyap
-- strict thread matches above, loose matches on Subject: below --
2010-10-21 18:19 Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox