Re: [PATCH v7 0/7] ufs: core: mcq: Add ufshcd_abort() and error handler support in MCQ mode

Can Guo
2023-05-30T05:24:33Z

Hi Bao,

On 5/30/2023 6:12 AM, Bao D. Nguyen wrote:
> This patch series enable support for ufshcd_abort() and error handler in MCQ mode.
>
> Bao D. Nguyen (7):
> ufs: core: Combine 32-bit command_desc_base_addr_lo/hi
> ufs: core: Update the ufshcd_clear_cmds() functionality
> ufs: mcq: Add supporting functions for mcq abort
> ufs: mcq: Add support for clean up mcq resources
> ufs: mcq: Added ufshcd_mcq_abort()
> ufs: mcq: Use ufshcd_mcq_poll_cqe_lock() in mcq mode
> ufs: core: Add error handling for MCQ mode
>
> drivers/ufs/core/ufs-mcq.c | 259 ++++++++++++++++++++++++++++++++++++++++-
> drivers/ufs/core/ufshcd-priv.h | 18 ++-
> drivers/ufs/core/ufshcd.c | 256 ++++++++++++++++++++++++++++++++--------
> drivers/ufs/host/ufs-qcom.c | 2 +-
> include/ufs/ufshcd.h | 5 +-
> include/ufs/ufshci.h | 23 +++-
> 6 files changed, 501 insertions(+), 62 deletions(-)
> ---
> Changes compared to v6:
> patch #7: Added a new argument force_compl to function ufshcd_mcq_compl_pending_transfer().
> Added a new function ufshcd_mcq_compl_all_cqes_lock().
> This change is to handle the case where the ufs host controller has been reset by
> the ufshcd_hba_stop() in ufshcd_host_reset_and_restore() prior to calling
> ufshcd_complete_requests(). The new logic is added to correctly complete all the
> commands that have been completed in the Completion Queue, or inform the scsi layer
> about those commands that are still stuck/pending in the hardware.
> ---

Feel free to my Reviewed-by tag to this series,

Reviewed-by: Can Guo<quic_cang@quicinc.com>

Thanks.
Regards,
Can Guo.