From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: David Sebek <dasebek@gmail.com>,
jejb@linux.ibm.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: Set BLIST_TRY_VPD_PAGES for WD Black P10 external HDD
Date: Tue, 01 Jun 2021 22:57:28 -0400 [thread overview]
Message-ID: <yq17djdq8ly.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <yq1czt5q8wu.fsf@ca-mkp.ca.oracle.com> (Martin K. Petersen's message of "Tue, 01 Jun 2021 22:53:35 -0400")
David,
Sorry for the partial mail, my VPN froze at an inopportune moment.
>> This patch adds this drive to the scsi_static_device_list
>> with a BLIST_TRY_VPD_PAGES flag. Although there are comments
>> in the code indicating that this list is deprecated and that
>> 'echo "WD:Game Drive:0x10000400" > /proc/scsi/device_info'
>> should be used instead, I haven't found a better place to
>> persist this information.
We just try to limit adding entries to cases where we fail to establish
a good heuristic.
>> + {"WD", "Game Drive", NULL, BLIST_TRY_VPD_PAGES | BLIST_INQUIRY_36},
Is BLIST_INQUIRY_36 really needed?
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-06-02 2:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 21:22 [PATCH] scsi: Set BLIST_TRY_VPD_PAGES for WD Black P10 external HDD David Sebek
2021-06-02 2:53 ` Martin K. Petersen
2021-06-02 2:57 ` Martin K. Petersen [this message]
2021-06-02 15:26 ` David Sebek
2021-06-11 2:10 ` Martin K. Petersen
2021-06-17 2:19 ` David Sebek
2021-06-19 1:55 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq17djdq8ly.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=dasebek@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox