From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: James Bottomley <jejb@linux.ibm.com>
Cc: Keyur Patel <iamkeyur96@gmail.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: aha1740: Use !x in place of NULL comparisons
Date: Thu, 11 Jul 2019 20:38:45 -0400 [thread overview]
Message-ID: <yq17e8o84tm.fsf@oracle.com> (raw)
In-Reply-To: <1562889124.2915.5.camel@linux.ibm.com> (James Bottomley's message of "Thu, 11 Jul 2019 16:52:04 -0700")
James,
> I also don't really think the replacement adds anything to readability,
> so it should probably be removed from the checkpatch warnings.
I agree.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2019-07-12 0:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 23:48 [PATCH] scsi: aha1740: Use !x in place of NULL comparisons Keyur Patel
2019-07-11 23:52 ` James Bottomley
2019-07-12 0:38 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq17e8o84tm.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=iamkeyur96@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).