From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH] scsi: aha1740: Use !x in place of NULL comparisons Date: Thu, 11 Jul 2019 20:38:45 -0400 Message-ID: References: <20190711234833.27475-1-iamkeyur96@gmail.com> <1562889124.2915.5.camel@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1562889124.2915.5.camel@linux.ibm.com> (James Bottomley's message of "Thu, 11 Jul 2019 16:52:04 -0700") Sender: linux-kernel-owner@vger.kernel.org To: James Bottomley Cc: Keyur Patel , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org James, > I also don't really think the replacement adds anything to readability, > so it should probably be removed from the checkpatch warnings. I agree. -- Martin K. Petersen Oracle Linux Engineering