Re: [PATCHv3 2/5] scsi: Export blacklist flags to sysfs

Hannes Reinecke
2017-08-15T08:03:52Z

On 08/15/2017 05:18 AM, Martin K. Petersen wrote:
>
> Hannes,
>
>> + name = sdev_bflags_name(bflags);
>> + if (name)
>> + blen = snprintf(ptr, strlen(name) + 1,
>> + "%s", name);
>> + else
>> + blen = snprintf(ptr, 67, "0x%X", bflags);
>
> It seems this else statement facilitates papering over the fact that
> scsi_sysfs.c and scsi_devinfo.h can get out of sync.
>
But there is no good way of avoiding that, is there?
Out of necessity the definition of the bits and the decoding are two
distinct steps, and as such are always prone to differences.

So what is your suggestion here?

Having the 'blacklist' sysfs entry gives us a nice way of figuring out
if the selection algorithm in scsi_devinfo.c works as designed.
Without it it's quite hard to validate this...

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)