Re: [PATCHv3 2/5] scsi: Export blacklist flags to sysfs

Hannes Reinecke
2017-08-15T14:58:35Z

On 08/15/2017 04:24 PM, Bart Van Assche wrote:
> On Fri, 2017-08-11 at 16:23 +0200, Hannes Reinecke wrote:
>> @@ -1138,6 +1220,7 @@ static umode_t scsi_sdev_bin_attr_is_visible(struct kobject *kobj,
>> &dev_attr_queue_depth.attr,
>> &dev_attr_queue_type.attr,
>> &dev_attr_wwid.attr,
>> + &dev_attr_blacklist.attr,
>> #ifdef CONFIG_SCSI_DH
>> &dev_attr_dh_state.attr,
>> &dev_attr_access_state.attr,
>
> Hello Hannes,
>
> Wouldn't debugfs be more appropriate for this attribute than sysfs?
>
I so don't mind.
I just need it somewhere in sysfs/debugfs so that I can validate the
selection logic.

Same goes for hexvalue vs decoded output; I just need to attribute;
contents can be discussed.

Martin?

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)