Re: [PATCHv3 2/5] scsi: Export blacklist flags to sysfs

Martin K. Petersen
2017-08-17T00:12:04Z

Hannes,

> I still would like to keep the above, as the admin can feed blacklist
> flags via the kernel commandline, and we don't do any validity checks on
> that. So we might end up with invalid flags after all.

I suggest you handle this by printing something along the lines of
"INVALID_BIT_SET(42)" for each bad flag.

Also: Brownie points for adding a new sysfs interface to augment the
existing /proc goo for adding entries. Preferably one that takes BLIST
names instead of huge hex numbers.

--
Martin K. Petersen Oracle Linux Engineering