RE: [PATCH] mpt2sas: Fix missing reference tag seed with Type 2 devices

Desai, Kashyap
2011-04-11T05:28:04Z

James,

We discuss this patch internally and found as valid candidate to be ACKed.
Please consider this patch as an ACKed.

Thanks, Kashyap

> -----Original Message-----
> From: Martin K. Petersen [mailto:martin.petersen@oracle.com]
> Sent: Tuesday, March 08, 2011 12:30 PM
> To: linux-scsi@vger.kernel.org; James.Bottomley@hansenpartnership.com;
> Desai, Kashyap; Moore, Eric
> Subject: [PATCH] mpt2sas: Fix missing reference tag seed with Type 2
> devices
>
>
> Ensure that the initial reference tag is passed on to the HBA firmware
> for DIF Type 2 devices.
>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
>
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> index 16e99b6..f423fe9 100644
> --- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> +++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> @@ -3230,6 +3230,7 @@ _scsih_setup_eedp(struct scsi_cmnd *scmd,
> Mpi2SCSIIORequest_t *mpi_request)
>
> switch (prot_type) {
> case SCSI_PROT_DIF_TYPE1:
> + case SCSI_PROT_DIF_TYPE2:
>
> /*
> * enable ref/guard checking
> @@ -3242,13 +3243,6 @@ _scsih_setup_eedp(struct scsi_cmnd *scmd,
> Mpi2SCSIIORequest_t *mpi_request)
> cpu_to_be32(scsi_get_lba(scmd));
> break;
>
> - case SCSI_PROT_DIF_TYPE2:
> -
> - eedp_flags |= MPI2_SCSIIO_EEDPFLAGS_INC_PRI_REFTAG |
> - MPI2_SCSIIO_EEDPFLAGS_CHECK_REFTAG |
> - MPI2_SCSIIO_EEDPFLAGS_CHECK_GUARD;
> - break;
> -
> case SCSI_PROT_DIF_TYPE3:
>
> /*