public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: linux-scsi@vger.kernel.org
Subject: [PATCH 0/4] SCSI: Printing cleanups
Date: Tue, 27 Feb 2007 22:39:05 -0500	[thread overview]
Message-ID: <yq17iu36jdy.fsf@sermon.lab.mkp.net> (raw)


This patch series is the first batch of cleanups in an attempt to make
the SCSI printing more consistent and suitable for human consumption.

Previously a typical error looked like this:

    sd 0:0:0:0: SCSI error: return code = 0x08000002
    sda: Current: sense key: Aborted Command
        Additional sense: Logical block reference tag check failed

You had to have the magic return value decoder ring handy to figure
out what had really happened.  And you had to do the mapping between
sd 0:0:0:0 and sda yourself.


The following patches clean up various bits so that the same
information can be presented in a more readable form:

    sd 0:0:0:0: [sda] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE,SUGGEST_OK
    sd 0:0:0:0: [sda] Sense Key : Aborted Command [current] 
    sd 0:0:0:0: [sda] Add. Sense: Logical block reference tag check failed

All printk's from sd.c now have the same prefix.  If logging is turned
on, for instance, we also get:

    sd 0:0:0:0: [sda] Send: 0x0fb89180 
    sd 0:0:0:0: [sda] CDB: Read(16): 88 20 00 00 00 00 00 00 00 20 00 00 00 08 00 00
    sd 0:0:0:0: [sda] Done: 0x0fb89180 SUCCESS

The patches need to be applied in order.

-- 
Martin K. Petersen	Oracle Linux Engineering


             reply	other threads:[~2007-02-28  3:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-28  3:39 Martin K. Petersen [this message]
2007-02-28  4:04 ` [PATCH 0/4] SCSI: Printing cleanups Douglas Gilbert
2007-02-28 17:09   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq17iu36jdy.fsf@sermon.lab.mkp.net \
    --to=martin.petersen@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox