From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: <linux-scsi@vger.kernel.org>, <hare@suse.de>,
<jejb@linux.ibm.com>, <martin.petersen@oracle.com>
Subject: Re: [PATCH] scsi: fcoe: fix possible name leak when device_register() fails
Date: Fri, 25 Nov 2022 19:20:23 -0500 [thread overview]
Message-ID: <yq18rjyr2gz.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20221112094310.3633291-1-yangyingliang@huawei.com> (Yang Yingliang's message of "Sat, 12 Nov 2022 17:43:10 +0800")
Yang,
> If device_register() returns error, the name allocated by
> dev_set_name() need be freed. As comment of device_register() says, it
> should use put_device() to give up the reference in the error path. So
> fix this by calling put_device(), then the name can be freed in
> kobject_cleanup().
Applied to 6.2/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-11-26 0:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-12 9:43 [PATCH] scsi: fcoe: fix possible name leak when device_register() fails Yang Yingliang
2022-11-26 0:20 ` Martin K. Petersen [this message]
2022-12-01 3:45 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18rjyr2gz.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox