From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: mwilck@suse.com
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: make "access_state" sysfs attribute always visible
Date: Mon, 07 Feb 2022 23:07:02 -0500 [thread overview]
Message-ID: <yq18rumxar1.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20220127141351.30706-1-mwilck@suse.com> (mwilck@suse.com's message of "Thu, 27 Jan 2022 15:13:51 +0100")
> If a SCSI device handler module is loaded after some SCSI devices have
> already been probed (e.g. via request_module() by dm-multipath), the
> "access_state" and "preferred_path" sysfs attributes remain invisible
> for these devices, although the handler is attached and live. The
> reason is that the visibility is only checked when the sysfs attribute
> group is first created. This results in an inconsistent user
> experience depending on the load order of SCSI low-level drivers
> vs. device handler modules.
>
> This patch changes user space API: attempting to read the
> "access_state" or "preferred_path" attributes will now result in
> -EINVAL rather than -ENODEV for devices that have no device handler,
> and tests for the existence of these attributes will have a different
> result.
Applied to 5.18/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-02-08 4:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 14:13 [PATCH] scsi: make "access_state" sysfs attribute always visible mwilck
2022-01-27 14:29 ` Hannes Reinecke
2022-02-08 4:07 ` Martin K. Petersen [this message]
2022-02-11 23:25 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18rumxar1.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox