From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jing Xiangfeng <jingxiangfeng@huawei.com>
Cc: <kartilak@cisco.com>, <sebaddel@cisco.com>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: snic: Remove unnecessary condition to simplify the code
Date: Fri, 02 Oct 2020 21:15:02 -0400 [thread overview]
Message-ID: <yq18scodsa8.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20200925060754.156599-1-jingxiangfeng@huawei.com> (Jing Xiangfeng's message of "Fri, 25 Sep 2020 14:07:54 +0800")
Jing,
> ret is always zero or an error in this code path. So the assignment to
> ret is redundant, and the code jumping to a label is unneed.
> Let's remove them to simplify the code. No functional changes.
Applied to 5.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-10-03 1:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 6:07 [PATCH] scsi: snic: Remove unnecessary condition to simplify the code Jing Xiangfeng
2020-09-25 6:58 ` Karan Tilak Kumar (kartilak)
2020-10-03 1:15 ` Martin K. Petersen [this message]
2020-10-07 3:47 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18scodsa8.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=jingxiangfeng@huawei.com \
--cc=kartilak@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox