From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH v4 2/2] scsi: ufs: Add UFS platform driver for Cadence UFS Date: Fri, 09 Nov 2018 08:11:11 -0500 Message-ID: References: <1A428C77-982A-4EB8-8FDD-A33979753660@global.cadence.com> <38D3DEAD-C318-4BE2-8605-102FF572AD45@global.cadence.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (John Garry's message of "Fri, 9 Nov 2018 11:51:59 +0000") Sender: linux-kernel-owner@vger.kernel.org To: John Garry Cc: "Martin K. Petersen" , Janek Kotas , "vinholikatti@gmail.com" , "jejb@linux.vnet.ibm.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" List-Id: linux-scsi@vger.kernel.org John, > I am building your 4.21 queue today, and it seems to be broken from > this patch: > > https://kernel.googlesource.com/pub/scm/linux/kernel/git/mkp/scsi/+/b3874a425510d1164fd3428ab99273c07d210d82 > > You seemed to miss adding the c-file: > make[3]: *** No rule to make target `drivers/scsi/ufs/cdns-pltfrm.o', > needed by `drivers/scsi/ufs/built-in.a'. Stop > > Or am I missing something? A corner case wrt. handling of new files in my pre-commit hook prevented the .c file from getting properly committed. Fixed up, thanks! -- Martin K. Petersen Oracle Linux Engineering