Re: [PATCH] scsi: mark expected switch fall-throughs

Martin K. Petersen
2018-10-16T02:47:40Z

Gustavo,

>> I'm not entirely convinced that all these identified fall through cases
>> are intentional. From a quick glance, some of them look like bugs...
>
> I took a second look at this and, certainly, the one below looks more like a
> bug. The rest seem to be false positives.

Yep.

>>> diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c
>>> index bd6ac6b..8e1c45d 100644
>>> --- a/drivers/scsi/ips.c
>>> +++ b/drivers/scsi/ips.c
>>> @@ -3485,6 +3485,7 @@ ips_send_cmd(ips_ha_t * ha, ips_scb_t * scb)
>>>
>>> case START_STOP:
>>> scb->scsi_cmd->result = DID_OK << 16;
>>> + /* fall through */
>
> If you confirm this is an actual bug, I can send a separate fix.

I believe it is. So please do.

--
Martin K. Petersen Oracle Linux Engineering