* [PATCH] scsi: qla2xxx: remove unused struct 'scsi_dif_tuple'
@ 2024-05-28 21:56 linux
2024-05-29 18:58 ` Himanshu Madhani
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: linux @ 2024-05-28 21:56 UTC (permalink / raw)
To: njavali, GR-QLogic-Storage-Upstream, James.Bottomley,
martin.petersen
Cc: linux-scsi, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
'scsi_dif_tuple' is unused since
commit 8cb2049c7448 ("[SCSI] qla2xxx: T10 DIF - Handle uninitalized
sectors.").
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/scsi/qla2xxx/qla_isr.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index d48007e18288..fe98c76e9be3 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -3014,12 +3014,6 @@ qla2x00_handle_sense(srb_t *sp, uint8_t *sense_data, uint32_t par_sense_len,
}
}
-struct scsi_dif_tuple {
- __be16 guard; /* Checksum */
- __be16 app_tag; /* APPL identifier */
- __be32 ref_tag; /* Target LBA or indirect LBA */
-};
-
/*
* Checks the guard or meta-data for the type of error
* detected by the HBA. In case of errors, we set the
--
2.45.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: qla2xxx: remove unused struct 'scsi_dif_tuple'
2024-05-28 21:56 [PATCH] scsi: qla2xxx: remove unused struct 'scsi_dif_tuple' linux
@ 2024-05-29 18:58 ` Himanshu Madhani
2024-05-31 0:27 ` Martin K. Petersen
2024-06-05 2:32 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Himanshu Madhani @ 2024-05-29 18:58 UTC (permalink / raw)
To: linux, njavali, GR-QLogic-Storage-Upstream, James.Bottomley,
martin.petersen
Cc: linux-scsi, linux-kernel
On 5/28/24 14:56, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'scsi_dif_tuple' is unused since
> commit 8cb2049c7448 ("[SCSI] qla2xxx: T10 DIF - Handle uninitalized
> sectors.").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
> drivers/scsi/qla2xxx/qla_isr.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index d48007e18288..fe98c76e9be3 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -3014,12 +3014,6 @@ qla2x00_handle_sense(srb_t *sp, uint8_t *sense_data, uint32_t par_sense_len,
> }
> }
>
> -struct scsi_dif_tuple {
> - __be16 guard; /* Checksum */
> - __be16 app_tag; /* APPL identifier */
> - __be32 ref_tag; /* Target LBA or indirect LBA */
> -};
> -
> /*
> * Checks the guard or meta-data for the type of error
> * detected by the HBA. In case of errors, we set the
Looks Good.
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: qla2xxx: remove unused struct 'scsi_dif_tuple'
2024-05-28 21:56 [PATCH] scsi: qla2xxx: remove unused struct 'scsi_dif_tuple' linux
2024-05-29 18:58 ` Himanshu Madhani
@ 2024-05-31 0:27 ` Martin K. Petersen
2024-06-05 2:32 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2024-05-31 0:27 UTC (permalink / raw)
To: linux
Cc: njavali, GR-QLogic-Storage-Upstream, James.Bottomley,
martin.petersen, linux-scsi, linux-kernel
> 'scsi_dif_tuple' is unused since commit 8cb2049c7448 ("[SCSI] qla2xxx:
> T10 DIF - Handle uninitalized sectors.").
>
> Remove it.
Applied to 6.11/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: qla2xxx: remove unused struct 'scsi_dif_tuple'
2024-05-28 21:56 [PATCH] scsi: qla2xxx: remove unused struct 'scsi_dif_tuple' linux
2024-05-29 18:58 ` Himanshu Madhani
2024-05-31 0:27 ` Martin K. Petersen
@ 2024-06-05 2:32 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2024-06-05 2:32 UTC (permalink / raw)
To: njavali, GR-QLogic-Storage-Upstream, James.Bottomley, linux
Cc: Martin K . Petersen, linux-scsi, linux-kernel
On Tue, 28 May 2024 22:56:40 +0100, linux@treblig.org wrote:
> 'scsi_dif_tuple' is unused since
> commit 8cb2049c7448 ("[SCSI] qla2xxx: T10 DIF - Handle uninitalized
> sectors.").
>
> Remove it.
>
>
> [...]
Applied to 6.11/scsi-queue, thanks!
[1/1] scsi: qla2xxx: remove unused struct 'scsi_dif_tuple'
https://git.kernel.org/mkp/scsi/c/96281dfa266d
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-05 2:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-28 21:56 [PATCH] scsi: qla2xxx: remove unused struct 'scsi_dif_tuple' linux
2024-05-29 18:58 ` Himanshu Madhani
2024-05-31 0:27 ` Martin K. Petersen
2024-06-05 2:32 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox