Re: [PATCH v5 00/52] Remove the request pointer from struct scsi_cmnd

Bart Van Assche
2021-08-10T16:19:40Z

On 8/9/21 10:28 PM, Martin K. Petersen wrote:
>> This patch series implements the following two changes for all SCSI drivers:
>> - Use blk_mq_rq_from_pdu() instead of the request member of struct scsi_cmnd
>> since adding an offset to a pointer is faster than pointer indirection.
>> - Remove the request pointer from struct scsi_cmnd.
>
> There were failures in storvsc and ufshpb. I fixed them up.

Hmm ... the basis of this patch series is commit 40fd8845c025 ("scsi:
target: core: Drop unnecessary se_cmd ASC/ASCQ members"). That was the
tip of the staging branch up until about two days ago. I'm not sure what
I missed?

> Also rebased my PI series on top and fixed scsi_logical_block_count() to
> use scsi_cmd_to_rq().

Thanks!

>> Please consider this patch series for kernel v5.14.
>
> A bit too late for 5.14 :)

Right, that part of the cover letter should have been updated.

Bart.