Re: [PATCH v5 02/52] core: Use scsi_cmd_to_rq() instead of scsi_cmnd.request

Hannes Reinecke
2021-08-10T06:17:36Z

On 8/10/21 1:03 AM, Bart Van Assche wrote:
> Prepare for removal of the request pointer by using scsi_cmd_to_rq()
> instead. Cast away constness where necessary when passing a SCSI command
> pointer to scsi_cmd_to_rq(). This patch does not change any functionality.
>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: Ming Lei <ming.lei@redhat.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/scsi/scsi.c | 2 +-
> drivers/scsi/scsi_error.c | 15 ++++++++-------
> drivers/scsi/scsi_lib.c | 28 +++++++++++++++-------------
> drivers/scsi/scsi_logging.c | 18 ++++++++++--------
> include/scsi/scsi_cmnd.h | 8 +++++---
> include/scsi/scsi_device.h | 16 +++++++++-------
> 6 files changed, 48 insertions(+), 39 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer