* Re: [PATCH v2] Avoid that ATA error handling can trigger a kernel hang or oops
[not found] ` <20180223164630.6ebe70dc@ncopa-desktop.copa.dup.pw>
@ 2018-02-26 11:52 ` Salvatore Bonaccorso
0 siblings, 0 replies; 4+ messages in thread
From: Salvatore Bonaccorso @ 2018-02-26 11:52 UTC (permalink / raw)
To: Natanael Copa
Cc: Bart Van Assche, Martin K . Petersen, James E . J . Bottomley,
linux-scsi, Damien Le Moal, Alexandre Oliva, Pavel Tikhomirov,
Hannes Reinecke, Johannes Thumshirn, stable, Jean-Francois Pirus
Hi,
On Fri, Feb 23, 2018 at 04:46:30PM +0100, Natanael Copa wrote:
> On Thu, 22 Feb 2018 11:30:20 -0800
> Bart Van Assche <bart.vanassche@wdc.com> wrote:
>
> > Avoid that the recently introduced call_rcu() call in the SCSI core
> > triggers a double call_rcu() call.
>
> This patch also prevents my machine from hanging. However, the ATA
> error messages that I previously have had are gone, so I don't know if
> it is because the underlying problem is gone, or if the error messages
> are simply not reported.
For reference, the patch has as well been confirmed to solve the
problem for Jean-Francois Pirus in https://bugs.debian.org/891467
(on top of 4.15.4)
Regards,
Salvatore
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] Avoid that ATA error handling can trigger a kernel hang or oops
[not found] <20180222193020.30276-1-bart.vanassche@wdc.com>
[not found] ` <20180223164630.6ebe70dc@ncopa-desktop.copa.dup.pw>
@ 2018-02-27 18:53 ` Bart Van Assche
2018-02-27 21:11 ` Damien Le Moal
2018-02-28 2:14 ` Martin K. Petersen
2 siblings, 1 reply; 4+ messages in thread
From: Bart Van Assche @ 2018-02-27 18:53 UTC (permalink / raw)
To: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com
Cc: jthumshirn@suse.de, Damien Le Moal, stable@vger.kernel.org,
oliva@gnu.org, linux-scsi@vger.kernel.org, hare@suse.com,
ptikhomirov@virtuozzo.com, ncopa@alpinelinux.org
On Thu, 2018-02-22 at 11:30 -0800, Bart Van Assche wrote:
> Avoid that the recently introduced call_rcu() call in the SCSI core
> triggers a double call_rcu() call.
> [ ... ]
Can anyone review this patch? Multiple users have confirmed independently
that this patch fixes the double call_rcu() issue for them.
Thanks,
Bart.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] Avoid that ATA error handling can trigger a kernel hang or oops
2018-02-27 18:53 ` Bart Van Assche
@ 2018-02-27 21:11 ` Damien Le Moal
0 siblings, 0 replies; 4+ messages in thread
From: Damien Le Moal @ 2018-02-27 21:11 UTC (permalink / raw)
To: Bart Van Assche, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com
Cc: jthumshirn@suse.de, stable@vger.kernel.org, oliva@gnu.org,
linux-scsi@vger.kernel.org, hare@suse.com,
ptikhomirov@virtuozzo.com, ncopa@alpinelinux.org
On 2018/02/27 10:53, Bart Van Assche wrote:
> On Thu, 2018-02-22 at 11:30 -0800, Bart Van Assche wrote:
>> Avoid that the recently introduced call_rcu() call in the SCSI core
>> triggers a double call_rcu() call.
>> [ ... ]
>
> Can anyone review this patch? Multiple users have confirmed independently
> that this patch fixes the double call_rcu() issue for them.
>
> Thanks,
>
> Bart.
Please feel free to add:
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
Tested-by: Damien Le Moal <damien.lemoal@wdc.com>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] Avoid that ATA error handling can trigger a kernel hang or oops
[not found] <20180222193020.30276-1-bart.vanassche@wdc.com>
[not found] ` <20180223164630.6ebe70dc@ncopa-desktop.copa.dup.pw>
2018-02-27 18:53 ` Bart Van Assche
@ 2018-02-28 2:14 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2018-02-28 2:14 UTC (permalink / raw)
To: Bart Van Assche
Cc: Martin K . Petersen, James E . J . Bottomley, linux-scsi,
Natanael Copa, Damien Le Moal, Alexandre Oliva, Pavel Tikhomirov,
Hannes Reinecke, Johannes Thumshirn, stable
Bart,
> Avoid that the recently introduced call_rcu() call in the SCSI core
> triggers a double call_rcu() call.
Applied to 4.16/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-28 2:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180222193020.30276-1-bart.vanassche@wdc.com>
[not found] ` <20180223164630.6ebe70dc@ncopa-desktop.copa.dup.pw>
2018-02-26 11:52 ` [PATCH v2] Avoid that ATA error handling can trigger a kernel hang or oops Salvatore Bonaccorso
2018-02-27 18:53 ` Bart Van Assche
2018-02-27 21:11 ` Damien Le Moal
2018-02-28 2:14 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox