From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: linux-scsi@vger.kernel.org, James.Bottomley@suse.de
Subject: [PATCH] scsi: Fix printing of variable length commands
Date: Mon, 18 Jan 2010 18:03:04 -0500 [thread overview]
Message-ID: <yq1aawbt3rr.fsf@sermon.lab.mkp.net> (raw)
The MAINTENANCE IN array is incorrectly used when decoding variable
length commands. Use the right array.
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---
diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.c
index 9129bcf..db68e3b 100644
--- a/drivers/scsi/constants.c
+++ b/drivers/scsi/constants.c
@@ -219,7 +219,7 @@ static void print_opcode_name(unsigned char * cdbp, int cdb_len)
break;
}
sa = (cdbp[8] << 8) + cdbp[9];
- name = get_sa_name(maint_in_arr, MAINT_IN_SZ, sa);
+ name = get_sa_name(variable_length_arr, VARIABLE_LENGTH_SZ, sa);
if (name) {
printk("%s", name);
if ((cdb_len > 0) && (len != cdb_len))
next reply other threads:[~2010-01-18 23:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 23:03 Martin K. Petersen [this message]
2010-01-19 9:49 ` [PATCH] scsi: Fix printing of variable length commands Boaz Harrosh
2010-01-20 7:17 ` Martin K. Petersen
2010-01-20 9:20 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1aawbt3rr.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox