From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
axboe@kernel.dk, matthew@wil.cx, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/2] block: Expose discard granularity
Date: Mon, 02 Nov 2009 08:31:08 -0500 [thread overview]
Message-ID: <yq1aaz59hpf.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20091030050719.GD17714@infradead.org> (Christoph Hellwig's message of "Fri, 30 Oct 2009 01:07:19 -0400")
>>>>> "Christoph" == Christoph Hellwig <hch@infradead.org> writes:
>> +static inline unsigned int queue_discard_granularity(struct
Christoph> Btw, I really hate these wrapper, they make followign the
Christoph> code much harder. Already annoyed me for the I/O topology
Christoph> bits.
They all follow the block layer calling conventions. They are also
there to prevent the disaster that was the topology merge which exposed
code all over the kernel that was poking directly at fields in struct
request.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2009-11-02 13:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-30 3:30 [RFC] Thin provisioning bits Martin K. Petersen
2009-10-30 3:30 ` [PATCH 1/2] block: Expose discard granularity Martin K. Petersen
2009-10-30 5:07 ` Christoph Hellwig
2009-11-02 13:31 ` Martin K. Petersen [this message]
2009-11-03 15:12 ` Christoph Hellwig
2009-11-03 19:08 ` Jens Axboe
2009-10-30 3:30 ` [PATCH 2/2] sd: WRITE SAME(16) / UNMAP support Martin K. Petersen
2009-10-30 4:28 ` Douglas Gilbert
2009-10-30 4:53 ` Martin K. Petersen
2009-10-30 16:02 ` Ric Wheeler
2009-10-30 5:11 ` Christoph Hellwig
2009-11-02 13:32 ` Martin K. Petersen
2009-11-03 15:12 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2009-11-04 4:25 Thin provisioning update Martin K. Petersen
2009-11-04 4:25 ` [PATCH 1/2] block: Expose discard granularity Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1aaz59hpf.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox