From: "Martin K. Petersen (Oracle)" <mkp@kernel.org>
To: Chen Changcheng <chenchangcheng@kylinos.cn>
Cc: <kartilak@cisco.com>, <nmusini@cisco.com>, <sebaddel@cisco.com>,
<ames.Bottomley@HansenPartnership.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<ccc194101@163.com>
Subject: Re: [PATCH] scsi: snic: Fix scsi host leak on workqueue allocation failure
Date: Sun, 23 Aug 2026 22:15:54 -0400 [thread overview]
Message-ID: <yq1bjasnu0t.fsf@mail.kernel.org> (raw)
In-Reply-To: <20260727073438.209673-1-chenchangcheng@kylinos.cn> (Chen Changcheng's message of "Mon, 27 Jul 2026 15:34:38 +0800")
Chen,
> In snic_add_host(), if scsi_add_host() succeeds but
> alloc_ordered_workqueue() fails, the function returns -ENOMEM with
> shost->work_q left as NULL. The caller's error path then calls
> snic_del_host(), which returns early when !shost->work_q without
> calling scsi_remove_host(). The Scsi_Host remains registered in sysfs
> as a zombie device even after the probe has failed. This causes:
Applied to 7.3/scsi-staging, thanks!
--
Martin K. Petersen
next prev parent reply other threads:[~2026-08-24 2:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 7:34 [PATCH] scsi: snic: Fix scsi host leak on workqueue allocation failure Chen Changcheng
2026-07-27 7:48 ` sashiko-bot
2026-07-27 23:50 ` Narsimhulu Musini (nmusini)
2026-08-24 2:15 ` Martin K. Petersen (Oracle) [this message]
2026-08-26 15:20 ` Martin K. Petersen (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1bjasnu0t.fsf@mail.kernel.org \
--to=mkp@kernel.org \
--cc=ames.Bottomley@HansenPartnership.com \
--cc=ccc194101@163.com \
--cc=chenchangcheng@kylinos.cn \
--cc=kartilak@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nmusini@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox