From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Sathya Prakash <sathya.prakash@broadcom.com>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Nagalakshmi Nandigama <Nagalakshmi.Nandigama@lsi.com>,
James Bottomley <JBottomley@Parallels.com>,
MPT-FusionLinux <MPT-FusionLinux.pdl@broadcom.com>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/1] scsi: mpt3sas: Fix error return value in _scsih_expander_add()
Date: Fri, 18 Jun 2021 22:53:47 -0400 [thread overview]
Message-ID: <yq1bl82wonh.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20210514081300.6650-1-thunder.leizhen@huawei.com> (Zhen Lei's message of "Fri, 14 May 2021 16:13:00 +0800")
Zhen,
> When an expander does not contain any 'phys', an appropriate error
> code -1 should be returned, as done elsewhere in this
> function. However, we currently do not explicitly assign this error
> code to 'rc'. As a result, 0 was incorrectly returned.
Applied to 5.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2021-06-19 2:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 8:13 [PATCH 1/1] scsi: mpt3sas: Fix error return value in _scsih_expander_add() Zhen Lei
2021-06-19 2:53 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1bl82wonh.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=JBottomley@Parallels.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=Nagalakshmi.Nandigama@lsi.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox