From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: chenxiang <chenxiang66@hisilicon.com>
Cc: <jejb@linux.vnet.ibm.com>, <martin.petersen@oracle.com>,
<linuxarm@huawei.com>, <linux-scsi@vger.kernel.org>,
<john.garry@huawei.com>
Subject: Re: [PATCH] scsi:sd: define variable dif as unsigned int instead of bool
Date: Thu, 24 Oct 2019 20:35:28 -0400 [thread overview]
Message-ID: <yq1blu5d5m7.fsf@oracle.com> (raw)
In-Reply-To: <1571725628-132736-1-git-send-email-chenxiang66@hisilicon.com> (chenxiang's message of "Tue, 22 Oct 2019 14:27:08 +0800")
> Variable dif in function sd_setup_read_write_cmnd() is the return
> value of function scsi_host_dif_capable() which returns dif capability
> of disks. If define it as bool, even for the disks which support
> DIF3, the function still return dif=1, which causes IO error. So
> define variable dif as unsigned int instead of bool.
Applied to 5.4/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2019-10-25 0:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 6:27 [PATCH] scsi:sd: define variable dif as unsigned int instead of bool chenxiang
2019-10-24 16:57 ` Bart Van Assche
2019-10-25 0:35 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1blu5d5m7.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=chenxiang66@hisilicon.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox