From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: tcmu: Simplify 'tcmu_update_uio_info()'
Date: Tue, 18 Jun 2019 21:10:40 -0400 [thread overview]
Message-ID: <yq1blyuxtv3.fsf@oracle.com> (raw)
In-Reply-To: <20190616070220.24189-1-christophe.jaillet@wanadoo.fr> (Christophe JAILLET's message of "Sun, 16 Jun 2019 09:02:20 +0200")
Christophe,
> Use 'kasprintf()' instead of:
> - snprintf(NULL, 0...
> - kmalloc(...
> - snprintf(...
>
> This is less verbose and saves 7 bytes (i.e. the space for '/(null)') if
> 'udev->dev_config' is NULL.
Applied to 5.3/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2019-06-19 1:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-16 7:02 [PATCH] scsi: tcmu: Simplify 'tcmu_update_uio_info()' Christophe JAILLET
2019-06-18 22:43 ` Michael Christie
2019-06-19 1:10 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1blyuxtv3.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).