From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-scsi@vger.kernel.org,
Douglas Gilbert <dgilbert@interlog.com>,
Robert Elliott <Elliott@hp.com>
Subject: Re: [PATCH 2/6] scsi: split scsi_nonblockable_ioctl
Date: Wed, 05 Nov 2014 09:28:56 -0500 [thread overview]
Message-ID: <yq1bnolen6f.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1414661229-15199-3-git-send-email-hch@lst.de> (Christoph Hellwig's message of "Thu, 30 Oct 2014 10:27:05 +0100")
>>>>> "Christoph" == Christoph Hellwig <hch@lst.de> writes:
Christoph> The calling conventions for this function where bad as it
Christoph> could return -ENODEV both for a device not currently online
Christoph> and a not recognized ioctl.
s/where/were/
Christoph> Add a new scsi_ioctl_block_when_processing_errors function
Christoph> that wraps scsi_block_when_processing_errors with the a
Christoph> special case for the SG_SCSI_RESET ioctl command, and handle
Christoph> the SG_SCSI_RESET case itself in scsi_ioctl. All callers of
Christoph> scsi_ioctl now must call the above helper to check for the EH
Christoph> state, so that the ioctl handler itself doesn't have to.
Nice cleanup!
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2014-11-05 14:29 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 9:27 misc scsi ioctl updates V2 Christoph Hellwig
2014-10-30 9:27 ` [PATCH 1/6] scsi: refactor scsi_reset_provider handling Christoph Hellwig
2014-10-30 9:38 ` Hannes Reinecke
2014-11-05 14:11 ` Hannes Reinecke
2014-11-05 14:25 ` Martin K. Petersen
2014-11-06 18:01 ` Elliott, Robert (Server Storage)
2014-10-30 9:27 ` [PATCH 2/6] scsi: split scsi_nonblockable_ioctl Christoph Hellwig
2014-11-05 14:12 ` Hannes Reinecke
2014-11-05 14:28 ` Martin K. Petersen [this message]
2014-11-06 22:35 ` Elliott, Robert (Server Storage)
2014-10-30 9:27 ` [PATCH 3/6] sd: fix up ->compat_ioctl Christoph Hellwig
2014-10-30 9:40 ` Hannes Reinecke
2014-11-05 14:13 ` Hannes Reinecke
2014-11-05 14:29 ` Martin K. Petersen
2014-11-06 21:41 ` Elliott, Robert (Server Storage)
2014-10-30 9:27 ` [PATCH 4/6] st: call scsi_set_medium_removal directly Christoph Hellwig
2014-11-05 14:13 ` Hannes Reinecke
2014-11-05 14:31 ` Martin K. Petersen
2014-11-06 23:54 ` Elliott, Robert (Server Storage)
2014-11-08 13:26 ` Christoph Hellwig
2014-11-09 19:18 ` "Kai Mäkisara (Kolumbus)"
2014-10-30 9:27 ` [PATCH 5/6] osst: " Christoph Hellwig
2014-11-05 14:14 ` Hannes Reinecke
2014-11-05 14:31 ` Martin K. Petersen
2014-11-07 0:01 ` Elliott, Robert (Server Storage)
2014-10-30 9:27 ` [PATCH 6/6] scsi: return EAGAIN when resetting a device under EH Christoph Hellwig
2014-11-05 14:14 ` Hannes Reinecke
2014-11-05 14:33 ` Martin K. Petersen
2014-11-06 21:46 ` Elliott, Robert (Server Storage)
2014-11-06 22:55 ` Douglas Gilbert
-- strict thread matches above, loose matches on Subject: below --
2014-10-27 17:59 misc scsi ioctl updates Christoph Hellwig
2014-10-27 17:59 ` [PATCH 2/6] scsi: split scsi_nonblockable_ioctl Christoph Hellwig
2014-10-28 9:05 ` Bart Van Assche
2014-10-28 17:39 ` Christoph Hellwig
2014-10-29 10:55 ` Bart Van Assche
2014-10-29 18:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1bnolen6f.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=Elliott@hp.com \
--cc=dgilbert@interlog.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox