From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: dgilbert@interlog.com,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Lukáš Czerner" <lczerner@redhat.com>
Subject: Re: [PATCH] scsi_debug: add LBPRZ support
Date: Thu, 08 Mar 2012 00:04:39 -0500 [thread overview]
Message-ID: <yq1boo7hee0.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <4F5808EB.9000909@redhat.com> (Eric Sandeen's message of "Wed, 07 Mar 2012 19:18:35 -0600")
>>>>> "Eric" == Eric Sandeen <sandeen@redhat.com> writes:
Eric> While we're talking about names, looking at other scsi_debug_*
Eric> flags should it be lbprz / scsi_debug_lbprz / DEF_LBPRZ instead of
Eric> unmap_zeroes / scsi_debug_unmap_zeroes / DEF_UNMAP_ZEROES?
Yeah, that's more consistent with my recent updates which use the lbpfoo
flag names.
>> Ah, and inquiry_evpd_b2() should return 4 (not 8).
Eric> Is that at all related to this change or some other random bug?
Eric> Should that return be unconditional? Should that be a separate
Eric> patch? By someone who knows what it means? :)
The returned page length should not include the length of the header. I
mess that up all the time. The spec says: "If the DP bit is set to
zero, then the page length shall be set to 0004h." The memset also needs
to be fixed accordingly.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2012-03-08 5:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 20:09 [PATCH] scsi_debug: add LBPRZ support Eric Sandeen
2012-03-08 1:00 ` Douglas Gilbert
2012-03-08 1:18 ` Eric Sandeen
2012-03-08 5:04 ` Martin K. Petersen [this message]
2012-03-08 6:03 ` [PATCH V2] " Eric Sandeen
2012-03-08 15:47 ` Martin K. Petersen
2012-03-08 15:48 ` Martin K. Petersen
2012-03-10 18:47 ` Douglas Gilbert
2012-03-10 18:45 ` Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1boo7hee0.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=dgilbert@interlog.com \
--cc=lczerner@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox