From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Michael Bommarito <michael.bommarito@gmail.com>
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org,
stable@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] xen/scsiback: fix command-tag handling on pre-completion error paths
Date: Mon, 15 Jun 2026 22:00:45 -0400 [thread overview]
Message-ID: <yq1cxxrutvh.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20260611123046.2323342-1-michael.bommarito@gmail.com> (Michael Bommarito's message of "Thu, 11 Jun 2026 08:30:44 -0400")
Michael,
> scsiback_get_pend_req() hands a pvSCSI frontend request a session tag
> and a zeroed se_cmd. Two error paths that run before the command
> completes through the target core mishandle that command and leak (or,
> in one case, underflow) the tag.
Applied to 7.2/scsi-staging, thanks!
--
Martin K. Petersen
prev parent reply other threads:[~2026-06-16 2:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 12:30 [PATCH 0/2] xen/scsiback: fix command-tag handling on pre-completion error paths Michael Bommarito
2026-06-11 12:30 ` [PATCH 1/2] xen/scsiback: free unsubmitted command instead of double-putting it Michael Bommarito
2026-06-15 15:14 ` Juergen Gross
2026-06-11 12:30 ` [PATCH 2/2] xen/scsiback: free the command tag on the TMR submit-failure path Michael Bommarito
2026-06-11 12:47 ` sashiko-bot
2026-06-11 13:06 ` Michael Bommarito
2026-06-15 15:14 ` Juergen Gross
2026-06-16 2:00 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1cxxrutvh.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michael.bommarito@gmail.com \
--cc=oleksandr_tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox