From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Carlos Bilbao <carlos.bilbao.osdev@gmail.com>
Cc: Dmitry Bogdanov <d.bogdanov@yadro.com>,
carlos.bilbao@kernel.org, bilbao@vt.edu,
martin.petersen@oracle.com, kees@kernel.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2] scsi: target: iscsi: reject invalid size Extended CDB AHS
Date: Mon, 13 Apr 2026 22:36:25 -0400 [thread overview]
Message-ID: <yq1cy02tgum.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <0657bd66-43df-43b0-97d0-16288595e229@gmail.com> (Carlos Bilbao's message of "Thu, 9 Apr 2026 19:49:01 -0700")
Carlos,
>>> + u16 cdb_length = ahslength - 1 + ISCSI_CDB_SIZE;
>> AFAIK, a variable declarationis allowed to be in the beginning of code block only.
>
> You're absolutely right, happy to send v3 if the maintainer prefers.
Yes, please. Best to stay consistent with the existing coding style in a
given file.
--
Martin K. Petersen
next prev parent reply other threads:[~2026-04-14 2:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-04 1:44 [PATCH] scsi: target: iscsi: reject zero-length Extended CDB AHS carlos.bilbao
2026-04-07 9:23 ` Dmitry Bogdanov
2026-04-09 2:23 ` Carlos Bilbao
2026-04-09 2:42 ` [PATCH v2] scsi: target: iscsi: reject invalid size " carlos.bilbao
2026-04-09 9:31 ` Dmitry Bogdanov
2026-04-10 2:49 ` Carlos Bilbao
2026-04-14 2:36 ` Martin K. Petersen [this message]
2026-04-15 4:07 ` [PATCH v3] " Carlos Bilbao (Lambda)
2026-04-15 4:08 ` [PATCH v2] " Carlos Bilbao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1cy02tgum.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=bilbao@vt.edu \
--cc=carlos.bilbao.osdev@gmail.com \
--cc=carlos.bilbao@kernel.org \
--cc=d.bogdanov@yadro.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox