From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Avri Altman <avri.altman@wdc.com>, Bean Huo <beanhuo@micron.com>,
Guixin Liu <kanie@linux.alibaba.com>,
Ziqi Chen <quic_ziqichen@quicinc.com>,
Arthur Simchaev <arthur.simchaev@sandisk.com>
Subject: Re: [PATCH] ufs: core: Remove an unnecessary NULL pointer check
Date: Wed, 12 Nov 2025 20:58:58 -0500 [thread overview]
Message-ID: <yq1cy5melro.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20251111184802.125111-1-bvanassche@acm.org> (Bart Van Assche's message of "Tue, 11 Nov 2025 10:47:59 -0800")
Bart,
> The !payload check tests the address of a member of a data structure.
> We know that the start address of this data structure (job) is not
> NULL since the 'job' pointer has already been dereferenced. Hence, the
> !payload check is superfluous. Remove this test. This was reported by
> the CodeSonar static analyzer.
Applied to 6.19/scsi-staging, thanks!
--
Martin K. Petersen
next prev parent reply other threads:[~2025-11-13 1:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 18:47 [PATCH] ufs: core: Remove an unnecessary NULL pointer check Bart Van Assche
2025-11-13 1:58 ` Martin K. Petersen [this message]
2025-11-20 4:15 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1cy5melro.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=arthur.simchaev@sandisk.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=kanie@linux.alibaba.com \
--cc=linux-scsi@vger.kernel.org \
--cc=quic_ziqichen@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox