From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: John Garry <john.g.garry@oracle.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org,
Douglas Gilbert <dgilbert@interlog.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: Re: [PATCH v2] scsi_debug: Make CRC_T10DIF support optional
Date: Sun, 10 Mar 2024 17:59:06 -0400 [thread overview]
Message-ID: <yq1cys1eoma.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <ef5dd96c-0de6-43bc-ba64-05729329ba2f@oracle.com> (John Garry's message of "Fri, 8 Mar 2024 09:45:47 +0000")
John,
> scsi_debug is complex, to put it gently. I don't see any value in
> splitting it into further files, spreading the complexity. More
> especially when there seems to be little gain. scsi_debug requires
> CRC_T10DIF, so let it have it.
Yeah, I'm not sure this is worth the effort. It's a debug driver.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2024-03-10 21:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 22:25 [PATCH v2] scsi_debug: Make CRC_T10DIF support optional Bart Van Assche
2024-03-06 13:19 ` John Garry
2024-03-06 18:27 ` Bart Van Assche
2024-03-07 9:37 ` John Garry
2024-03-07 17:59 ` Bart Van Assche
2024-03-08 9:45 ` John Garry
2024-03-10 21:59 ` Martin K. Petersen [this message]
2024-03-11 18:34 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1cys1eoma.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=bvanassche@acm.org \
--cc=dgilbert@interlog.com \
--cc=jejb@linux.ibm.com \
--cc=john.g.garry@oracle.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox