Re: [PATCH] scsi: Set BLIST_TRY_VPD_PAGES for WD Black P10 external HDD

["Martin K. Petersen" <martin.petersen@oracle.com>]

David,

>(Currently, there is a bug and Linux incorrectly enables a writesame_16
>TRIM operation on the drive

This is intentional as we support devices which conform to an earlier
version of the spec that did not have the LBP VPD indicating which
command to use for discards.

I have a patch impending that postpones enabling WRITE SAME until after
all VPD pages have been queried. That gives us a slightly better
heuristic and removes a window of error for devices that report
conflicting limits for UNMAP and WRITE SAME.

> This patch adds this drive to the scsi_static_device_list
> with a BLIST_TRY_VPD_PAGES flag. Although there are comments
> in the code indicating that this list is deprecated and that
> 'echo "WD:Game Drive:0x10000400" > /proc/scsi/device_info'
> should be used instead, I haven't found a better place to
> persist this information.





Moreover, the list already contains
> a similar entry for the SanDisk Cruzer Blade USB flash drive.
>
> Signed-off-by: David Sebek <dasebek@gmail.com>
> ---
>  drivers/scsi/scsi_devinfo.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
> index d92cec12454c..3ed558c168be 100644
> --- a/drivers/scsi/scsi_devinfo.c
> +++ b/drivers/scsi/scsi_devinfo.c
> @@ -256,6 +256,7 @@ static struct {
>  	{"WangDAT", "Model 2600", "01.7", BLIST_SELECT_NO_ATN},
>  	{"WangDAT", "Model 3200", "02.2", BLIST_SELECT_NO_ATN},
>  	{"WangDAT", "Model 1300", "02.4", BLIST_SELECT_NO_ATN},
> +	{"WD", "Game Drive", NULL, BLIST_TRY_VPD_PAGES | BLIST_INQUIRY_36},
>  	{"WDC WD25", "00JB-00FUA0", NULL, BLIST_NOREPORTLUN},
>  	{"XYRATEX", "RS", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
>  	{"Zzyzx", "RocketStor 500S", NULL, BLIST_SPARSELUN},

-- 
Martin K. Petersen	Oracle Linux Engineering