From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dave Carroll <david.carroll@microsemi.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
James Bottomley <jejb@linux.vnet.ibm.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
dl-esc-Aacraid Linux Driver <aacraid@microsemi.com>,
Scott Benesh <scott.benesh@microsemi.com>,
Brian King <brking@linux.vnet.ibm.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH RESEND] aacraid: Fix 2T+ drives on SmartIOC-2000
Date: Fri, 15 Sep 2017 21:10:34 -0400 [thread overview]
Message-ID: <yq1d16rtpmd.fsf@oracle.com> (raw)
In-Reply-To: <423FD6710FB8FB4F8728F93591889F9A5B8BDE73@avsrvexchmbx1.microsemi.net> (Dave Carroll's message of "Fri, 15 Sep 2017 23:37:23 +0000")
Dave,
> Hi Christoph,
>
>> > + if ((le32_to_cpu(dresp->status) == ST_OK) &&
>> > + (le32_to_cpu(dresp->mnt[0].vol) != CT_NONE)) {
>> > + _aac_probe_container2(context, fibptr);
>> > + return;
>>
>> if (dresp->status == cpu_to_le32(ST_OK) &&
>> dresp->mnt[0].vol != cpu_to_le32(CT_NONE)) {
>>
>
> I've contemplated this all day, and it looked like sematics, but I
> assume you were Indicating that the cpu_to_le32() of a constant is a
> compiler issue, vs le32_to_cpu() is a runtime issue. If so, thanks! If
> not could you elaborate ...
FWIW, I applied your patch as-is for consistency with the rest of the
driver. I do prefer Christoph's version, though, but that can be a
follow-on patch.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-09-16 1:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 17:04 [PATCH RESEND] aacraid: Fix 2T+ drives on SmartIOC-2000 Dave Carroll
2017-09-15 18:01 ` Christoph Hellwig
2017-09-15 23:37 ` Dave Carroll
2017-09-16 1:10 ` Martin K. Petersen [this message]
2017-09-17 1:23 ` Dave Carroll
2017-09-15 19:20 ` Raghava Aditya Renukunta
2017-09-15 19:50 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d16rtpmd.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=aacraid@microsemi.com \
--cc=brking@linux.vnet.ibm.com \
--cc=david.carroll@microsemi.com \
--cc=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=scott.benesh@microsemi.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).