public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Douglas Gilbert <dgilbert@interlog.com>
Cc: SCSI development list <linux-scsi@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>,
	Boaz Harrosh <bharrosh@panasas.com>
Subject: Re: [PATCH] sg: limit maximum cdb size to 252 bytes
Date: Wed, 25 Jun 2014 22:19:52 -0400	[thread overview]
Message-ID: <yq1d2dwcszb.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <53AB0166.8060905@interlog.com> (Douglas Gilbert's message of "Wed, 25 Jun 2014 13:05:42 -0400")

>>>>> "Doug" == Douglas Gilbert <dgilbert@interlog.com> writes:

Doug> Boaz Harrosh commented on the "[PATCH v5] sg: relax 16 byte cdb
Doug> restriction" thread that SCSI variable length commands (which are
Doug> all SCSI commands greater than 16 bytes long) must themselves be a
Doug> multiple of 4 bytes long.

Doug> ChangeLog
Doug>   - limit the maximum cdb size permitted by the sg
Doug>     v3 interface to 252 bytes. Commands that large are called
Doug>     "variable length" and their length needs to be a multiple of
Doug>     4.

Doug> Original patch:
Doug>   Reviewed-by: Boaz Harrosh <boaz@electrozaur.com>

Doug> Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2014-06-26  2:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-25 17:05 [PATCH] sg: limit maximum cdb size to 252 bytes Douglas Gilbert
2014-06-26  2:19 ` Martin K. Petersen [this message]
2014-06-26  7:38 ` Christoph Hellwig
2014-06-26 14:57 ` Ewan Milne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1d2dwcszb.fsf@sermon.lab.mkp.net \
    --to=martin.petersen@oracle.com \
    --cc=bharrosh@panasas.com \
    --cc=dgilbert@interlog.com \
    --cc=hch@lst.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox