From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Daan De Meyer <daan.j.demeyer@gmail.com>
Cc: linux-scsi@vger.kernel.org,
James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, Daan De Meyer <daan@amutable.com>
Subject: Re: [PATCH RESEND] scsi: sr: exclude CDC_MRW_W and CDC_RAM from writeable check
Date: Tue, 21 Apr 2026 22:01:36 -0400 [thread overview]
Message-ID: <yq1eck7lq27.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20260415065110.3496246-2-daan@amutable.com> (Daan De Meyer's message of "Wed, 15 Apr 2026 06:51:11 +0000")
Daan,
> The writeable check in get_capabilities() includes CDC_MRW_W and
> CDC_RAM in its bitmask, but these capabilities are not determined from
> the MODE SENSE capabilities page. They require the SCSI GET
> CONFIGURATION command, which is only issued later by
> cdrom_open_write() at device open time.
Reviewing this involved quite a bit of digging through ancient specs...
I don't particularly like how that decision process is split between
sr.c and cdrom.c.
My preference would be to defer setting the device writable state until
after GET CONFIGURATION has been called in cdrom.c.
--
Martin K. Petersen
next prev parent reply other threads:[~2026-04-22 2:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 6:51 [PATCH RESEND] scsi: sr: exclude CDC_MRW_W and CDC_RAM from writeable check Daan De Meyer
2026-04-22 2:01 ` Martin K. Petersen [this message]
2026-04-22 11:44 ` Daan De Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1eck7lq27.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=daan.j.demeyer@gmail.com \
--cc=daan@amutable.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox