From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai3@huawei.com, zhangwensheng5@huawei.com,
yi.zhang@huawei.com
Subject: Re: [PATCH -next] [RFC] scsi: ses: fix slab-out-of-bounds in ses_enclosure_data_process
Date: Mon, 01 Aug 2022 20:01:06 -0400 [thread overview]
Message-ID: <yq1edxz349n.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20220713094548.3958915-1-yukuai1@huaweicloud.com> (Yu Kuai's message of "Wed, 13 Jul 2022 17:45:48 +0800")
> After analysis on vmcore, it was found that the line "desc_ptr[len] =
> '\0';" has slab-out-of-bounds problem in ses_enclosure_data_process.
> In ses_enclosure_data_process, "desc_ptr" point to "buf", so it have
> to be limited in the memory of "buf", however. although there is
> "desc_ptr >= buf + page7_len" judgment, it does not work because
> "desc_ptr + 4 + len" may bigger than "buf + page7_len", which will
> lead to slab-out-of-bounds problem.
>
> Fix it by using judging desc_ptr cross the border or not after
> "desc_ptr += 4".
FWIW, I tested this change and I am still getting KASAN errors from ses.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-08-02 0:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 9:45 [PATCH -next] [RFC] scsi: ses: fix slab-out-of-bounds in ses_enclosure_data_process Yu Kuai
2022-08-02 0:01 ` Martin K. Petersen [this message]
2022-08-02 1:19 ` zhangwensheng (E)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1edxz349n.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
--cc=zhangwensheng5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox